address DOM text reinterpreted as HTML alert#38949
Conversation
|
/gemini review |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses security concerns related to how DOM elements are queried and how HTML content is rendered within tooltips. By enforcing stricter scoping for selectors and introducing a sanitization step for dynamic content, the changes reduce the risk of malicious script execution and improve the robustness of the UI components. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Bootstrap JS files to use $(document).find(selector) instead of $(selector) and introduces HTML sanitization for tooltips using DOMPurify. The review feedback highlights two critical issues: first, calling $(document).find() with a falsy selector will throw a SyntaxError in jQuery, so guards must be added to return an empty jQuery collection instead; second, sanitizing tooltip content when html is false can cause regressions by stripping plain text characters, so sanitization should only be applied when html is true.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request updates several Bootstrap JavaScript components to query elements using $(document).find(selector) instead of direct jQuery selections, and introduces HTML sanitization for tooltips using DOMPurify. The review feedback correctly highlights that passing empty, null, or undefined selectors to $(document).find() will throw jQuery syntax errors, and recommends adding truthy guards to prevent runtime crashes. Additionally, the feedback suggests adding a type check in the sanitizeHtml function to ensure only string values are passed to DOMPurify.sanitize.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request updates several Bootstrap JavaScript components to scope element lookups to the document using $(document).find(selector) and introduces HTML sanitization for tooltips using DOMPurify. The review feedback highlights two critical issues: first, the sanitizeHtml function needs a safe HTML-escaping fallback to prevent XSS vulnerabilities if DOMPurify is unavailable; second, lookups with $(document).find(selector) should be wrapped in try/catch blocks to prevent jQuery syntax errors from crashing script execution when handling invalid selectors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces safer jQuery selector querying across several Bootstrap components by wrapping selector lookups in try-catch blocks. It also adds HTML sanitization for tooltips using DOMPurify with a fallback escaping mechanism. The review feedback correctly highlights that the fallback escaping mechanism in sanitizeHtml will break the html: true option for tooltips and popovers when DOMPurify is unavailable, as it escapes all HTML tags and renders them as plain text. It is recommended to return the string unmodified if DOMPurify is not present to avoid visual regressions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @damccorm for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
2 participants
Fix CodeQL DOM text alerts
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.